Page 6 of 12

Re: SNS-HDR Pro 2.0 Beta

PostPosted: Wed Aug 17, 2016 9:00 pm
by Sebastian Nibisz
capricorn wrote:Nope. No trailing blank after the closing double quote:

I added a white space in the latest version, it must be removed outside of the application. I'm surprised that it exists in version 1.

Re: SNS-HDR Pro 2.0 Beta

PostPosted: Thu Aug 18, 2016 6:26 am
by capricorn
What's even more surprising is the fact that mhardisty seems to have no problem at all in reimporting the HDR file back into LR.

@mhardisty:
Is that working for you only since 2.0.0.8, or even before?
Can you provide the contents of .snshdr_callback for your above example (preferrably in hex)?
This file should be located in your "%TEMP" folder, in some subfolder like eg "BA7DD82B-0E3E-4C47-A2F4-70678FF155A9".

I assume you are using the original, not modified version of the plugin?
Ie. in line 73 of SNSHDRProcess.lua file there is the statement "return string.sub(processedImage, 2, -3)",

Thanks
Karsten

Re: SNS-HDR Pro 2.0 Beta

PostPosted: Thu Aug 18, 2016 6:35 am
by mhardisty
I'll try and have a go today. Got a lot on though so it may be afternoon before I come back to you. As to the plugin, I only recently downloaded it. I wasn't aware there was an original and a modified version

Re: SNS-HDR Pro 2.0 Beta

PostPosted: Thu Aug 18, 2016 7:00 am
by mhardisty
Lightroom-LUA.jpg
Lightroom-LUA.jpg (312 KiB) Viewed 7644 times


I'm not a programmer or anything, best I can do is open the file in notepad and do a screenshot from the file

I wasn't really using the plugin before I updated to SNS 2.0.0.9

I'll try and find this other file you want. Not quite sure where to g but Google is my friend, or at least I hope so in this case

Re: SNS-HDR Pro 2.0 Beta

PostPosted: Thu Aug 18, 2016 9:14 am
by mhardisty
Another screenshot, I hope this is what you need

Re: SNS-HDR Pro 2.0 Beta

PostPosted: Thu Aug 18, 2016 9:18 am
by Joghi
Just an idea: would´nt it be easier to change the programming of the plugin?
greez Joghi

Re: SNS-HDR Pro 2.0 Beta

PostPosted: Thu Aug 18, 2016 6:52 pm
by capricorn
Joghi wrote:Just an idea: would´nt it be easier to change the programming of the plugin?

I agree. Initially I was hoping that Sebastian could design the new version so that it seamlessly interfaces with the plugin by Michael. Now, having arrived at a point where trailing blanks matter maybe it's time to reconsider. In fact, the portion of the plugin that removes unwanted characters from the output file name is poorly coded since it assumes a fixed structure of the string. I have changed the original "return string.sub(processedImage, 2, -3)" to

return string.match(LrStringUtils.trimWhitespace(processedImage), '[^"]+')

which works for all combinations of filenames with and without trailing blanks and/or double quotes as produced by SNS-HDR versions 1.4.22, 1.x, 2.0.0.6 and 2.0.0.9.

In case anyone is interested, here is the file that needs to be replaced:
SNSHDRProcess.zip
(2.73 KiB) Downloaded 462 times


Question is how to make this easily available to SNS-HDR users.

Sebastian, how about providing an update of the plugin in the corresponding forum section?

Re: SNS-HDR Pro 2.0 Beta

PostPosted: Thu Aug 18, 2016 7:56 pm
by Sebastian Nibisz
Thanks. I sent a request to update this file to the author of the plugin.

Re: SNS-HDR Pro 2.0 Beta

PostPosted: Sat Aug 20, 2016 8:09 am
by Joghi
Great done, Capricorn! Thank you very much.

greez Johgi

Re: SNS-HDR Pro 2.0 Beta

PostPosted: Sat Aug 20, 2016 9:10 am
by nette
Great job! The only thing I miss is the preset "dramatical".
When will the final version be available? And will the owners of the "Home" license get the upgrade too?

Greetz
Nette