SNS-HDR Forum

capricorn wrote:The problem is that the output filename passed back to the plugin gets truncated during further processing by the plugin code. This is the reason why no output file is found where it should be. After reading the filename from snshdr_callback the plugin trims leading and pending quotes - which do exist in SNS-HDR 1 but they don't in v2.

Please check the new version (2.0.0.7).
I also enabled option for the 360° panorama mode.

sebastian please integrates DCRaw 9.27 in the beta of SNS-HDR 2

Sebastian Nibisz wrote:Please check the new version (2.0.0.7).

I'm sorry, the handover of the HDR to LR still does not work.

I converted one image using SNS-HDR 1.x and 2. Here is the contents of the .snshdr_callback file:
1.x -> "C:\Temp\3AC36594-A71E-45C4-A191-4FCC01EB599E\P3015506_HDR_1.tif"
2 ----> c:\temp\b9d52a7c-7738-4117-bdbb-bbf0c192c5c3\p3015506_hdr_1.tif

The quotes are still missing in v2 which causes the LR plugin to return a "wrong" (crippled) file name due to "return string.sub(processedImage, 2, -3)".
(meanwhile I know how to fix it myself, but others probably won't and it's not compatible with 1.x).

And, interestingly v2 now completely converts the tif file name to lower case instead of upper case before?
What is the source of that case conversion?
Sure, this is just cosmetics and has nothing to do with the logic.

I noticed another thing regarding the control flow when working with the LR plugin that I really would like to see improved.

Once the HDR image is ready I used to click "x" (close window) in 1.x.
I was then asked if I want to save the file, and after doing so the program closed and LR took over again.
v2 asks me if I want to save the project. I don't want to because I just want the HDR, so I explicitely save the HDR file.
Upon clicking "x" I am asked again if I want to save the file!?

My wish setting for this type of thing would be the following:
User can define in Preferences whether he wants to work with SNS project or TIF file by default.
Whenever the program shall be exited, the corresponding data will be saved.
Does that make sense?

Darkbeat wrote:sebastian please integrates DCRaw 9.27 in the beta of SNS-HDR 2

Done.

capricorn wrote:The quotes are still missing in v2 which causes the LR plugin to return a "wrong" (crippled) file name due to "return string.sub(processedImage, 2, -3)".
(meanwhile I know how to fix it myself, but others probably won't and it's not compatible with 1.x).

Please check the new version, I changed the Qt callback function.

capricorn wrote:Once the HDR image is ready I used to click "x" (close window) in 1.x.
I was then asked if I want to save the file, and after doing so the program closed and LR took over again.
v2 asks me if I want to save the project. I don't want to because I just want the HDR, so I explicitely save the HDR file.
Upon clicking "x" I am asked again if I want to save the file!?

I fixed this.

Version 2.0.0.8

Also I added the "quiet" mode for the command line options.

Thank you Sebastian. I'll try it now.

Sebastian Nibisz wrote:Please check the new version, I changed the Qt callback function.

Many thanks for the quick fix, Sebastian. Much appreciated!

Unfortunately, I need to report that the behaviour is still not compatible with Michael Koetters plugin. There is slight difference in .snshdr_callback file that causes the plugin code to work with wrong output file name.

SNS-HDR v1:
00000000 22 43 3A 5C ¦ 54 65 6D 70 ¦ 5C 34 34 38 ¦ 45 44 32 38 "C:\Temp\448ED28
00000010 41 2D 44 45 ¦ 44 33 2D 34 ¦ 45 35 31 2D ¦ 38 30 38 37 A-DED3-4E51-8087
00000020 2D 37 39 43 ¦ 36 43 44 41 ¦ 41 41 44 34 ¦ 36 5C 50 33 -79C6CDAAAD46\P3
00000030 30 31 35 35 ¦ 33 30 5F 48 ¦ 44 52 5F 31 ¦ 2E 74 69 66 015530_HDR_1.tif
00000040 22 20 0D 0A ¦ " ??

SNS-HDR v2:
00000000 22 63 3A 5C │ 74 65 6D 70 │ 5C 30 33 65 │ 63 31 38 66 "c:\temp\03ec18f
00000010 36 2D 30 63 │ 35 32 2D 34 │ 38 61 62 2D │ 62 39 63 36 6-0c52-48ab-b9c6
00000020 2D 38 65 38 │ 32 32 32 31 │ 36 62 66 31 │ 63 5C 70 33 -8e822216bf1c\p3
00000030 30 31 35 35 │ 33 30 5F 68 │ 64 72 5F 31 │ 2E 74 69 66 015530_hdr_1.tif
00000040 22 0D 0A "♪◙

For some reason, in v1 there was a trailing blank after the file name that was considered to be removed along with the quotes by

SNSHDRProcess.lua#73 return string.sub(processedImage, 2, -3)

Maybe this helps to do the final amendment so that everybody can use the existing plugin with the new version of SNS-HDR

Thanks
Karsten

capricorn wrote:Unfortunately, I need to report that the behaviour is still not compatible with Michael Koetters plugin. There is slight difference in .snshdr_callback file that causes the plugin code to work with wrong output file name.

Thanks. One more attempt.
Version 2.0.0.9

Nope. No trailing blank after the closing double quote:

v.2.0.0.9:
00000000 22 43 3A 5C │ 54 65 6D 70 │ 5C 43 39 34 │ 41 33 39 39 "C:\Temp\C94A399
00000010 33 2D 44 38 │ 45 42 2D 34 │ 39 36 39 2D │ 39 46 31 36 3-D8EB-4969-9F16
00000020 2D 38 31 31 │ 33 43 30 43 │ 30 32 41 38 │ 30 5C 50 33 -8113C0C02A80\P3
00000030 30 31 35 37 │ 31 30 5F 53 │ 4E 53 48 44 │ 52 5F 31 2E 015710_SNSHDR_1.
00000040 74 69 66 22 │ 0D 0A tif"♪◙

That's strange the plugin is working for me. I've tried it five times now with different bracket sets. Once I press Save in SNS the program does it's business and then minimises. Lightroom doesn't automatically open up, it's running minimised on the desktop at this point but if I click on it the file is there from SNS. File name is xxxxxxxx_SNSHDR_5.tif. Where the x's are the last file name in a bracket set of 5

Just an update to my post. I was running Windows 10 in Tablet mode. When I switched back to normal desktop mode. Lightroom did not minimise when I sent the Bracket set to SNS.